rg.el icon indicating copy to clipboard operation
rg.el copied to clipboard

Prefer project-root to project-roots

Open manuel-uberti opened this issue 4 years ago • 3 comments

Hi,

first of all thanks for this great package.

May I suggest to use project-root instead of project-roots in rg-project-root? project-roots is deprecated.

Thank you!

manuel-uberti avatar Oct 19 '20 06:10 manuel-uberti

Thanks for the kind words and the suggestion.

This change is too new to get from emacs internally since this package supports emacs-25.1. It's possible to have it as a requirement of course and get a newer version from elpa but since the project system used is optional I don't really want to depend on any of them explicitly.

I'll keep this open and see what to do. Maybe just check if project-root is available and us it if it is.

dajva avatar Oct 19 '20 16:10 dajva

Totally understand your point. Feel free to close this whenever you like.

manuel-uberti avatar Oct 19 '20 19:10 manuel-uberti

Maybe just check if project-root is available and us it if it is.

Now that Emacs 28 is out, perhaps its time to do this.

hmelman avatar Apr 19 '22 17:04 hmelman