hltv-api icon indicating copy to clipboard operation
hltv-api copied to clipboard

feat: include liveMatches in matches response

Open Ma-ve opened this issue 3 years ago • 4 comments

  • Adds isLive (bool) to the matches response
  • Adds a new endpoint, getLiveMatchById

edit: aww, the build is failing. I can't see why though. I've got one local warning that I can't seem to get rid of, which occurs when running npm run build. It does still properly build though. The error:


> @ma-ve/[email protected] build
> tsc -p .

node_modules/cheerio/lib/options.d.ts:29:24 - error TS2304: Cannot find name 'URL'.

29     baseURI?: string | URL;
                          ~~~


Found 1 error in node_modules/cheerio/lib/options.d.ts:29

This occurs on any branch. I'm not that well versed in TS so I haven't got the slightest what's up.

Ma-ve avatar Nov 06 '22 20:11 Ma-ve

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hltv-api ❌ Failed (Inspect) Nov 16, 2022 at 8:58PM (UTC)

vercel[bot] avatar Nov 06 '22 20:11 vercel[bot]

@dajk Loving your project! Are you open to Pull requests? :-)

Ma-ve avatar Nov 06 '22 20:11 Ma-ve

Hi @Ma-ve ,

Thanks for contributing!

@dajk Loving your project! Are you open to Pull requests? :-)

Yes, sure. I will have a look what's wrong with the build ;)

dajk avatar Nov 12 '22 01:11 dajk

@dajk Hi @Ma-ve ,

Thanks for contributing!

@dajk Loving your project! Are you open to Pull requests? :-)

Yes, sure. I will have a look what's wrong with the build ;)

Cool, thank you!

Ma-ve avatar Nov 13 '22 22:11 Ma-ve