Added ability to filter player stats by event type and date
Also edited README.md to show how requests should be made now.
This is also my first pull request ever, so if I'm doing anything wrong, just let me know :)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| hltv-api | ✅ Ready (Inspect) | Visit Preview | Nov 14, 2022 at 3:56AM (UTC) |
Initial PR had a problem with the TS files. Sorry about that. Should be fixed now!
Hey @hnjpedro ,
Thanks for contributing!
How useful is to have that since eventId is not something we know from anywhere. How would one know which id to pass?
Hey @hnjpedro ,
Thanks for contributing!
How useful is to have that since
eventIdis not something we know from anywhere. How would one know which id to pass?
Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. I'm still fairly new to this, so I don't know if this is bad practice.
The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with.
This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR.
If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html
Hey @hnjpedro , Thanks for contributing! How useful is to have that since
eventIdis not something we know from anywhere. How would one know which id to pass?Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. I'm still fairly new to this, so I don't know if this is bad practice.
The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with.
This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR.
If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html
Ok, makes sense, I think I mixed that with something else.
I can see that you are introducing too few breaking changes (player interface), please keep your pull request minimal, revert all the configuration file changes (e.g. package.json)..
Hey @hnjpedro , Thanks for contributing! How useful is to have that since
eventIdis not something we know from anywhere. How would one know which id to pass?Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. I'm still fairly new to this, so I don't know if this is bad practice. The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with. This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR. If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html
Ok, makes sense, I think I mixed that with something else.
I can see that you are introducing too few breaking changes (player interface), please keep your pull request minimal, revert all the configuration file changes (e.g. package.json)..
Hey! I've reverted the changes to package.json. These were accidental.
Do you think I should make any additional changes to the other files?