react-daisyui icon indicating copy to clipboard operation
react-daisyui copied to clipboard

ThemeItem not exported

Open taivo opened this issue 3 years ago • 3 comments

The documentation at https://react.daisyui.com/?path=/story/utils-theme--default refers to the ThemeItem tag but it doesn't look like it's exported for external use.

taivo avatar Jan 19 '23 02:01 taivo

Hi @taivo,

The <ThemeItem> component was never intended to be exported; it only exists for the sake of the Storybook. After all, it's not a component found in the daisy-ui design system. What do you want to use it for?

benjitrosch avatar Jan 19 '23 04:01 benjitrosch

Hi @benjitrosch , Thanks for maintaining this excellent package!

I mainly suggest exporting <ThemeItem> because that tag was used in the docs example https://react.daisyui.com/?path=/story/utils-theme--default . There is a potential for confusion here for new users of the theming feature.

If you don't want to export, perhaps an alternative is to update the docs.

That said, it seems to me this tag would be a useful building block for theme selection by end users.

taivo avatar Jan 19 '23 05:01 taivo

I got the same impression as @taivo and was also trying to use the ThemeItem as part of a user-facing theme picker. It would be nice to have a built-in ThemePicker component that used the look in the storybook to show themes, or like the one on the DaisyUI site.

stacygrace avatar Mar 10 '23 17:03 stacygrace