react-daisyui icon indicating copy to clipboard operation
react-daisyui copied to clipboard

Published 20 hours ago • verified publisher icon daisyui

Create Tests for components

Open redxzeta opened this issue 2 years ago • 13 comments

Unit / Integration testing especially for all the stateful components

redxzeta avatar Jun 24 '22 00:06 redxzeta

  • [x] Alert
  • [x] Artboard
  • [x] Avatar
  • [x] Badge
  • [ ] Breadcrumbs
  • [x] Button
  • [ ] ButtonGroup
  • [ ] Card
  • [ ] Carousel
  • [ ] Checkbox
  • [ ] CodeMockup
  • [ ] Collapse
  • [ ] Countdown
  • [ ] Divider
  • [ ] Drawer
  • [ ] Dropdown
  • [x] Footer
  • [ ] Form
  • [ ] Hero
  • [ ] Indicator
  • [ ] Input
  • [ ] InputGroup
  • [ ] Kbd
  • [ ] Link
  • [ ] Mask
  • [ ] Menu
  • [x] Modal
  • [ ] Navbar
  • [ ] Pagination
  • [ ] PhoneMockup
  • [ ] Progress
  • [ ] RadialProgress
  • [x] Radio
  • [x] Range
  • [ ] Rating
  • [ ] Select
  • [ ] Stack
  • [ ] Stats
  • [ ] Steps
  • [ ] Swap
  • [ ] Table
  • [x] Tabs
  • [x] Textarea
  • [ ] Theme
  • [x] Toggle
  • [ ] Tooltip
  • [ ] WindowMockup

redxzeta avatar Jun 24 '22 14:06 redxzeta

@benjitrosch May i get assigned this issue please?

imtheaman avatar Jul 03 '22 10:07 imtheaman

@urtheaman Sure, thank you!

benjitrosch avatar Jul 03 '22 14:07 benjitrosch

@benjitrosch Thanks.

imtheaman avatar Jul 04 '22 05:07 imtheaman

@urtheaman how many of the tests did you cover? wondering if I could pick some of the leftover

redxzeta avatar Jul 19 '22 02:07 redxzeta

Hey @redxzeta, could you please do from 32-47(RadialProgress - WindowMockup)? I'm involved in multiple things right now, but i'll make the pr soon.

imtheaman avatar Jul 19 '22 05:07 imtheaman

@urtheaman Have you made any progress on any tests? I would prefer if you didn't "claim" any and instead simply make a PR per component as you finish them. That way we avoid blocking others who wish to contribute, and also keep the PR's a manageable size.

benjitrosch avatar Aug 16 '22 20:08 benjitrosch

@benjitrosch okay. some of them are remaining. I'll submit 'em today or tomorrow. Thanks.

imtheaman avatar Aug 17 '22 03:08 imtheaman

@benjitrosch I need some more time. hard to manage time b/w work, learnings and open source contributions.

imtheaman avatar Aug 18 '22 12:08 imtheaman

@urtheaman There's no pressure to do everything, and it's probably better that you don't! You can always just PR what you have and contribute more in the future depending on your schedule 😄

benjitrosch avatar Aug 22 '22 14:08 benjitrosch

sure! once i finish the bugs on my current project(which will be done in 2-3 days). i'll be free for few days.

On Mon, Aug 22, 2022 at 7:45 PM Benji @.***> wrote:

@urtheaman https://github.com/urtheaman There's no pressure to do everything, and it's probably better that you don't! You can always just PR what you have and contribute more in the future depending on your schedule 😄

— Reply to this email directly, view it on GitHub https://github.com/daisyui/react-daisyui/issues/137#issuecomment-1222424279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7QZ4HBBZNLEQJUZH7ZGODV2ODRXANCNFSM5ZWCWSXQ . You are receiving this because you were mentioned.Message ID: @.***>

imtheaman avatar Aug 23 '22 11:08 imtheaman

Hi, is this checklist up to date? I might be able to help write some tests.

erichartline avatar Sep 16 '22 18:09 erichartline

@wildlifehexagon I believe so!

Ignore any comments claiming specific components, all PR's will be accepted on a first come first serve basis. So take whichever you like!

benjitrosch avatar Sep 16 '22 19:09 benjitrosch

May i get assigned some of them? (like around 2-3 would be good) I'm new to open source contribution so picking not really complicated ones for me would be appreciated ! Thanks

wjdwl002 avatar Oct 15 '22 16:10 wjdwl002

Hi @wjdwl002,

Feel free to try any you would like. I will not be assigning components to anybody, but will review PR's as they come in. All of the components should be easy to test (for the most part they're light on state), so you can't go wrong in choosing!

benjitrosch avatar Oct 19 '22 13:10 benjitrosch

Hi @benjitrosch, is there a reason this got closed? It would be helpful to have an updated list of components that still need testing!

dev0T avatar Apr 19 '23 19:04 dev0T