TwitFix icon indicating copy to clipboard operation
TwitFix copied to clipboard

Published 20 hours ago • verified publisher icon daisyUniverse

Improve support for photo links

Open rcombs opened this issue 2 years ago • 2 comments

This implements the change I suggested at https://github.com/robinuniverse/TwitFix/issues/44#issuecomment-1065567675

Additionally cleans up the matching a bit, tweaks the readme, fixes a missing entry in requirements.txt, and simplifies local testing a little.

I haven't fully tested this end-to-end, as I don't have twitter API access set up, but everything seems to behave as expected in the logs.

rcombs avatar Mar 11 '22 22:03 rcombs

This looks good to me so far from my testing, but I need to tweak it a bit to make it pick up url encoded endings (ie using /photo/2 or /2 on the end of a twitter link with encoded endings, IE) image

daisyUniverse avatar Mar 12 '22 17:03 daisyUniverse

in a related issue I REALLY need to learn how regex works :smiling_face_with_tear:

daisyUniverse avatar Mar 12 '22 17:03 daisyUniverse