Daira-Emma Hopwood

While reviewing #1687 I noticed that we are not running clippy on the Rust sources in `backend-lib`. There are a bunch of shallow lint failures, mainly [needless_borrows](https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow) and one [needless_question_mark](https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark),...

Originally posted by @daira in https://github.com/Electric-Coin-Company/zcash-android-wallet-sdk/pull/1640#discussion_r1882167888 > The valid range of a ZIP 32 account index is $[0, 2^{31})$, not $[0, 2^{32})$.

Originally posted by @nuttycom in https://github.com/Electric-Coin-Company/zcash-android-wallet-sdk/pull/1640#discussion_r1880613354 : > ```kotlin > /** > * The binary encoding of the [ZIP 316](https://zips.z.cash/zip-0316) Unified Spending > * Key for [accountUuid]. > * >...

@str4d: > consider altering the Rust FFI backend to filter by threshold and then select the first taddr after that (so it doesn't get stuck always trying to select a...

This has been corrected from `.transaparent`. fixes #1401

A ZIP 321 URI with filename-unsafe characters (e.g. `+`) is reportedly accepted when it MUST NOT be according to the spec

3

ZIP 321 says, of the base64url memo field: > "base64url" is defined as in [4] with padding omitted. (Note that this uses a different alphabet to the usual base64; the...

This would have caused new address book entries not to be written (after the first remote store of the file). This code review checklist is intended to serve as a...

This explorer is calculating fees incorrectly for Zcash transactions with shielded components. Example: https://zecblockexplorer.com/tx/63679fc7f9628bc5065636813ee6adbe89f6dfdf3635524ac0792b344a9fd588 shows a fee of 72.56179835 ZEC. In fact this is a shielding transaction which transfers 72.56024835...

### Motivation See https://github.com/zcash/sinsemilla/issues/3 and https://github.com/ZcashFoundation/zebra/pull/9426 .

* ZIP 302