Daira-Emma Hopwood comments

Results 725 comments of


                                            Daira-Emma Hopwood

Modify `query_instance` API to take an absolute row rather than a relative `Rotation`

Why is there a `query_instance` method at all? With the other `query_*` methods, the aim is to be able to construct a gate polynomial that references the given column at...

Clarify constraint descriptor for v_old and root == anchor to indicate inclusive OR

To me this means the same thing?

How do I upgrade to the new version?

Are you sure that you're running the version that you built? The executable is built at `src/zcashd`. You may be picking up a different version from your `PATH`.

[WIP]Feat/zcash

``` //is versionGroupId still needed? ``` The purpose of `versionGroupId` is to unambiguously identify the transaction format even if version numbers are reused across Zcash forks, and that's still relevant...

Document the policy for deciding which version of a dependency to use

The issue in #1241 looks like it has been reported but not fixed in boost: https://svn.boost.org/trac/boost/ticket/11097

crypto/rand: crash process on error reading randomness

Do you mean crypto/rand should [panic](https://go.dev/ref/spec#Handling_panics) on errors? I'm not very familiar with Go but I didn't think it used the terminology of "throwing" errors. I agree, on general language-independent...

backport: merge bitcoin#6589, #7003, #7087, #7180, #7181, #7257, #7570, #7906, #8049, #8065, #8083, #8168, #8102, #7749, #8113, #8128, partial bitcoin#7136, #8038 (networking backports)

Approved to run through CI (this is not a review).

rename the build.rs such that it's not run by default

I just don't think we should make this change. The `build.rs` is doing precisely what a `build.rs` should do: the source is the `.proto` files, not the generated `.rs` files....

Please make diff colors configurable

I intend to make these configurable in daira/git-gui#1. It's required anyway for contrast adjustment in dark mode, but thanks for reminding me of the colour blindness motivation.