Daira-Emma Hopwood

Results 725 comments of Daira-Emma Hopwood

I'm marking this as blocking zcash/zips#387 because we need to decide whether it is useful for ZIP 311, and close it or kick it into the long grass if not.

~~Tbh I'm kind of -1 on this whole PR; I think we should just fix the merge conflicts when we pull in subsequent PRs. (The formatting change is useful but...

What's the use case for this that can't be satisfied by transparent transactions?

I asked what the use case was. The current reasons I know of to use t-addresses are: they are faster, they support multisig and HTLC, and they have wider ecosystem...

> It's not currently supported in wallets, but there are no changes needed to the protocol for a wallet to to add a "make this transaction public" checkbox which then...

The verification key serialization should include the number of public input elements.

I think I never actually confirmed the assertion that $p$ and $q$ can be swapped safely in that implementation, or what exactly it depends on. The security analysis was done...

The general approach looks promising. I'll have a closer look soon.

@AloeareV The first comment in a PR goes into the merge commit, so it should reflect the current state of the PR. Can you update it please?