Daira-Emma Hopwood comments

Results 725 comments of


                                            Daira-Emma Hopwood

Add tl::expected and some examples of its use

@str4d would like this to be brought in [in the same way as utfcpp](https://github.com/zcash/zcash/blob/master/depends/packages/utfcpp.mk).

Add tl::expected and some examples of its use

This is ready for re-review.

Add tl::expected and some examples of its use

I filed a PR upstream to https://github.com/TartanLlama/expected/pull/117 for the assertion failure change.

Crash in DecrementNoteWitnesses after a reorg

Please keep a backup of the node directory from before running with `-rescan`.

Support unified full and incoming viewing key import & export.

#5519 claims to have implemented the export part.

Consider supporting Orchard spending key import & export.

The format of Orchard raw spending keys is defined in [section 5.6.4.5 of the protocol spec](https://zips.z.cash/protocol/protocol.pdf#orchardspendingkeyencoding). Currently we have no code that reads or writes this format, I think.

Allow or require columns to be named

I think it would be sufficient for this issue to just pass a closure returning a column name to methods like `ConstraintSystem::{advice,fixed}_column`. At the moment, circuits tend to manually share...

Out-of-memory when downloading blockchain

Did you create any shielded addresses in the wallet of this node?

Add `encrypt-to-recipient` feature to `zcash_note_encryption`

This needs to be specified: https://github.com/zcash/zips/issues/633

Add `encrypt-to-recipient` feature to `zcash_note_encryption`

The nonce for IETF_CHACHA20_POLY1305 is 96 bits. That means that if you encrypt a large number of plaintexts with this feature using the same epk, you might get a nonce...