Daira-Emma Hopwood

Results 724 comments of Daira-Emma Hopwood

Yes, that's exactly the situation.

How would you suggest I clarify 4.3? Maybe say "hSig as computed above" in the consensus rule I quoted?

I agree; this is an oversight.

It should be consistent with Sapling. There's a minor technical problem in that the type of fs.AddressList is a sequence of strings (see [ZIP 214](https://zips.z.cash/zip-0214#mainnet-recipient-addresses)), and there is no direct...

We'd love a Halo 2 implementation in Arkworks! It's a bit early to do that, though.

The second problem (`root_path` vs `root_and_path`) is just in the implementation of the `tuple_name` function of https://hg.python.org/cpython/file/4d4a9094bdb0/Lib/lib2to3/fixes/fix_tuple_params.py . The first is because at line 68, `self.new_name` is called without an...

I don't see a straightforward, idiomatic way to replace `cmp=` with `key=`. https://wiki.python.org/moin/HowTo/Sorting#The_Old_Way_Using_the_cmp_Parameter gives a way to do so using an auxiliary class, but: - the code for this isn't...

[functools.cmp_to_key](https://docs.python.org/2/library/functools.html#functools.cmp_to_key) is only in Python 2.7, and we claim to support Python 2.6. We could make it an opt-in fixer I suppose.

The cookbook would be http://python3porting.com/ -- I believe @brettcannon had plans to update it to recommend python-modernize.