Daijiro Fukuda
Daijiro Fukuda
It seems that `Console.logger = Fluent::Log::ConsoleAdapter.wrap(@logger)` is not applied to this thread. https://github.com/fluent/fluentd/blob/bf7498d6ff2805bfa517bbd6f7c17103c7d879d4/lib/fluent/plugin_helper/http_server.rb#L74-L76
`Console.logger=` sets the value as `Fiber::local::instance`. This is why `Console.logger = Fluent::Log::ConsoleAdapter.wrap(@logger)` is not applied to other threads. https://github.com/socketry/console/blob/main/lib/console.rb#L13-L19 https://github.com/socketry/console/blob/main/lib/console/logger.rb#L19-L20 https://github.com/socketry/fiber-local/blob/main/lib/fiber/local.rb#L34-L53
We may have to do something like this... Maybe there is a more correct way... ```diff --- a/lib/fluent/plugin_helper/http_server/server.rb +++ b/lib/fluent/plugin_helper/http_server/server.rb @@ -40,7 +40,6 @@ module Fluent @uri = URI("#{scheme}://#{@addr}:#{@port}").to_s @router...
Note: We have to consider the possibility of `Async::HTTP::Server::run()` creating child tasks inside. (If so, how should we apply our logger to the child tasks' threads?)
I commented below on what I think needs clarification in the specifications. * https://github.com/fluent/fluent-plugin-rewrite-tag-filter/pull/16#issuecomment-1980608455
I think there is no progress. We still need this workaround for `fluent-plugin-systemd` in some environments. @mszabo Could you share your environment information? Are you using Ubuntu?
> > * [IME input glfw/glfw#41](https://github.com/glfw/glfw/issues/41) > > * [Add IME support for each platform glfw/glfw#2130](https://github.com/glfw/glfw/pull/2130) > > Thanks a lot! This turned out to be supported in glfw. I'll...
@jdeokkim @raysan5 Thanks! It may take a while to be merged in GLFW. If it is not a problem, we would like to send a PR in draft status and...
@raysan5 Thanks! I will open the PR in draft soon!