Daijiro Fukuda
Daijiro Fukuda
> @daipom some doubts here > > in chuck open method for decompress we dont have any type identification. how to identify the chunk type while open/read method is called...
Sorry I have been busy this week :cry: Thanks! I will check it out!
@Athishpranav2003 > hey @daipom sorry to ping again. would be good if i can wrap this up soon Sorry for my late response :cry: I was busy releasing Fluentd v1.18...
@Athishpranav2003 Sorry for my late response. Overall, it looks great! Thanks so much! About `out_file` and `out_forward`, it would be better that we do not support setting a different compression...
@yugeeklab I have pushed the commits for https://github.com/fluent/fluentd/pull/4491#issuecomment-2162508391.
> In addition, it would be happy if we can simplify `FIFO#read_lines` to make easy to read although I have no idea about it yet. What do you think about...
Thanks! I will see this this weekend!
@Athishpranav2003 Sorry for my late response. I got COVID-19 last weekend and only got a little work done this week :cry: I will see this now, please wait a few...
> It appears that adding some inner methods would improve code readability. > For example ... I guess we need to think a little better about handling error events...
> @daipom yah I wanted to make sure we are in same page. I will refactor the code and change the error part after that Thanks! This would be the...