Daijiro Fukuda
Daijiro Fukuda
@ashie Can I add a commit about the points I am commenting on?
> > @ashie Can I add a commit about the points I am commenting on? > > Of course. Done. The new tests on macOS seem to be unstable. I...
The new tests are unstable on Windows or macOS. We need to check if we need to fix these tests or if in_tail on Windows or macOS can not collect...
I'm sorry for the interval. I'm checking again on the new tests on Windows and macOS.
I will merge this if it is confirmed that the newly added tests are stable. Please let me know if anyone has concerns.
The new tests are now stable. However, I have noticed that we need to consider `rotate_wait 0` case.
> However, I have noticed that we need to consider rotate_wait 0 case. I am concerned about the possibility of the key being deleted before the key is added. Although...
> > However, I have noticed that we need to consider rotate_wait 0 case. > > I am concerned about the possibility of the key being deleted before the key...
> I will remove this fix, and check the following codes as well. > > https://github.com/fluent/fluentd/pull/4334/files#diff-456fdeb51bc472beb48891caac0d063e0073655dba7ac2b72e6fdc67dc6ac802R272-R275 The callbacks of timers are not called after the `Stop` phase. So we don't...
The code for conflicts with timer execution is unnecessary, so I have removed them. @ashie Thanks and sorry I overlooked this.