AndroidImageSlider icon indicating copy to clipboard operation
AndroidImageSlider copied to clipboard

Compatible with the las Picasso Version

Open albetoetecnia opened this issue 6 years ago • 15 comments

Please, make compatible with the last picasso version, in BaseSliderView.java

Last version: com.squareup.picasso:picasso:2.71828

albetoetecnia avatar Jul 25 '18 08:07 albetoetecnia

@albetoetecnia Library already compatible with latest version. Just set up your picasso Java: textSliderView.setPicasso(Picasso.get()); or Kotlin: textSliderView.picasso = Picasso.get()

P.S. @daimajia Thanks for library 😄

YuraAAA avatar Aug 06 '18 12:08 YuraAAA

BaseSliderView.java is Cannot be modified,read-only Not solved

guikaiAndroid avatar Aug 28 '18 02:08 guikaiAndroid

@Gui-kai Please check this answer https://github.com/daimajia/AndroidImageSlider/issues/291#issuecomment-302918655

YuraAAA avatar Aug 28 '18 09:08 YuraAAA

@YuraAAA Nice! I used CustomBaseSliderView replace textSliderView,But I found a problem.No animation is loaded, and CustomBaseSliderView should have a ProgressBar like textSliderView when a network connection is abnormal,I hope to be able to.thank you very much

guikaiAndroid avatar Aug 29 '18 02:08 guikaiAndroid

@YuraAAA Excuse me,The problem has been solved.thank you very much

guikaiAndroid avatar Aug 29 '18 02:08 guikaiAndroid

still error if with proguard

Warning: com.daimajia.slider.library.SliderTypes.BaseSliderView: can't find referenced method 'com.squareup.picasso.Picasso with(android.content.Context)' in program class com.squareup.picasso.Picasso

j3p0n avatar Oct 23 '18 10:10 j3p0n

still error if with proguard

Warning: com.daimajia.slider.library.SliderTypes.BaseSliderView: can't find referenced method 'com.squareup.picasso.Picasso with(android.content.Context)' in program class com.squareup.picasso.Picasso

Did you extends BaseSliderView? Can you please paste your code?

YuraAAA avatar Oct 23 '18 10:10 YuraAAA

App build run correctly and app launch correctly in debug mode, error hapend when build with proguard enabled and minifyEnabled true, this is my proguard config

-keepnames class okhttp3.internal.publicsuffix.PublicSuffixDatabase -dontwarn javax.annotation.** -keepnames class okhttp3.internal.publicsuffix.PublicSuffixDatabase -dontwarn org.codehaus.mojo.animal_sniffer.* -dontwarn okhttp3.internal.platform.ConscryptPlatform

j3p0n avatar Oct 24 '18 02:10 j3p0n

Same here.

The problem is here: library/src/main/java/com/daimajia/slider/library/SliderTypes/BaseSliderView.java Line 210

Picasso doesn't have anymore .with method "Picasso.with(mContext)" It should be like this instead (without using context param) : "Picasso.get()"

Someone can make a fork and and this library to maven so we can use it with this fix?

burekas7 avatar Jan 09 '19 12:01 burekas7

@YuraAAA Thanks, it works.

burekas7 avatar Jan 09 '19 12:01 burekas7

I followed all the steps ,still I am getting this error with proguard enabled. com.daimajia.slider.library.SliderTypes.BaseSliderView: can't find referenced method 'com.squareup.picasso.Picasso with(android.content.Context)' in program class com.squareup.picasso.Picasso Please, make compatible with the last picasso version.

KhadkaRabindra avatar Mar 26 '19 11:03 KhadkaRabindra

@KhadkaRabindra I think you can exclude this class from proguard config :)

YuraAAA avatar Mar 26 '19 13:03 YuraAAA

@YuraAAA I can't get it . what is Picasso in Picasso.get()? and how can change picasso version? i need to use com.squareup.picasso:picasso:2.71828

Masoudmjm avatar Apr 08 '19 06:04 Masoudmjm

@Masoudmjm i think you can clone/download project, add as library and modify picasso dependency :)

YuraAAA avatar Apr 08 '19 10:04 YuraAAA

You can check this library https://github.com/OpenSooq/Pluto it has the ability to have full control over your views and layout and not depending on any image library

tamtom avatar May 05 '19 11:05 tamtom