docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: DocSearch covered by nav because of z-index

Open gabrielkoo opened this issue 3 years ago • 2 comments

Resolves #159

Background

The current issue with DocSearch modal being covered by nav bar arose as a side effect of the fix in #112 and #113.

In #112, an attempt was made to avoid the Youtube videos' "total time" to be floating on the top nav by making the nav's z-index to be 9999. It did solve the issue but it caused #159 too.

In #113 the issue was fully fixed by adjusting the z-index of the "total time" element itself, so the fix in #112 was no longer necessary.

Actually, the z-index for the top nav is already managed by z-index: var(--ifm-z-index-fixed); so manually specifying a value while not using CSS variables might easily break other styles.

Screenshots

Before After
docs daily dev_video-tutorials localhost_3000_video-tutorials

Tests

Tested the following functionalities are working on the preview site: https://docs-git-fork-gabrielkoo-fix-modal-covered-by-nav-dailydotdev.vercel.app/video-tutorials

  • [x] DocSearch Modal is no longer blocked by top nav
  • [x] Youtube video "total time" is not floating on top nav

gabrielkoo avatar Oct 10 '22 02:10 gabrielkoo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 10 '22 02:10 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 2:53AM (UTC)

vercel[bot] avatar Oct 10 '22 02:10 vercel[bot]

@GrahamTheDev Could you help reviewing this pull request? This feature should be quite troublesome for some users 😢.

gabrielkoo avatar Oct 21 '22 10:10 gabrielkoo

thanks

FrancescoXX avatar Oct 28 '22 12:10 FrancescoXX