docs icon indicating copy to clipboard operation
docs copied to clipboard

consistent footer container align with logo & card list align in homPage

Open AliDhuniya opened this issue 2 years ago • 4 comments

see the changes in the screenshot:

from this

Screenshot (306)

to

Screenshot (307)

from this

Screenshot (308)

to

Screenshot (309)

hacktoberfest-2022-vibe

AliDhuniya avatar Oct 01 '22 06:10 AliDhuniya

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 01 '22 06:10 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 1, 2022 at 6:40AM (UTC)

vercel[bot] avatar Oct 01 '22 06:10 vercel[bot]

Thank you for the PR.

Cards

For the cards that you fixed, the problem was not alignment, it was that there is a "chevron" that appears that is white so it doesn't show in light mode (see pic below in dark mode).

chevron that shows in dark mode

A fix for this potentially could be to use a CSS filter to invert the SVG colour. If you want to take that just let us know!

Footer

The footer is visually as expected, removing the padding-left breaks the balance of the page and makes the "Product" column too close to the left of the page.

If you want to fix this I suggest making the footer container have more left padding to restore the original visual style.

GrahamTheDev avatar Oct 02 '22 08:10 GrahamTheDev

Ah! please do assign how about aligning footer container in center, would that be ok or should I give more left padding on footer container. Thanks for helpful reply

AliDhuniya avatar Oct 02 '22 11:10 AliDhuniya