daily icon indicating copy to clipboard operation
daily copied to clipboard

🐛 BUG: Profile card popup opens automatically on focus (Accessibility)

Open Efury1 opened this issue 3 months ago • 17 comments

What went wrong? 🤔

When navigating with the keyboard (Tab), moving focus onto a profile card automatically opens a popup without the user pressing Enter.

This breaks accessibility expectations and violates WCAG 2.1 – On Focus (3.2.1) , which states that elements should not trigger context changes on focus.

Expected Behavior

Expected Behavior

Focusing on the card should only highlight it.

The popup should not open automatically.

Personally, I think pressing Enter should open the profile page itself (not a preview popup).

That would be more consistent with accessibility best practices.

Otherwise, if a popup is kept, it would require capturing focus inside the popup and managing tab order properly, which makes things more complicated and less intuitive.

Steps to Reproduce Issue

Navigate the feed using Tab.

Focus on a profile card.

Observe that a popup opens automatically without activation.

Solution Proposed

  1. Remove the onFocus trigger for the popup for tab

  2. On enter open the full profile page directly, instead of a popup preview, to simplify focus handling and improve accessibility.

Screenshots

Image below shows card with tab focus Image

Environment

No response

Browsers

Chrome

OS

Windows

Version of daily.dev

Most recent version

Additional Context


Code of Conduct

  • [x] I follow the conditions of this project.

Efury1 avatar Sep 09 '25 19:09 Efury1

Let me know your thoughts and if this is something you have thought about.

Efury1 avatar Sep 09 '25 19:09 Efury1

Hi @Efury1,

Great catch! We'd love to see it gets fixed if you wish to contribute.

idoshamun avatar Sep 14 '25 07:09 idoshamun

Hi, I’d love to contribute! I’ll start looking into it today and will reach out if I have any questions about the codebase :)

Efury1 avatar Sep 14 '25 10:09 Efury1

Amazing!

idoshamun avatar Sep 14 '25 10:09 idoshamun

@Efury1 feel free to head to our GitPod setup for local development! 🥳

sshanzel avatar Sep 16 '25 06:09 sshanzel

@sshanzel Thank you, I've got it working on there now :D

Efury1 avatar Sep 19 '25 05:09 Efury1

I tried pushing my branch (fix/1949-profile-card-autofocus) but I’m getting this error:

$ git push -u origin fix/1949-profile-card-autofocus
remote: {"auth_status":"access_denied_to_user","body":"Permission to dailydotdev/daily.git denied to Efury1."}
fatal: unable to access 'https://github.com/dailydotdev/daily.git/': The requested URL returned error: 403

Has anyone else run into this issue before? And what did you do to fix it?

Efury1 avatar Sep 24 '25 22:09 Efury1

Hi @Efury1! For you to be able to raise a PR, you'll have to fork the repo, then push to a branch there. After doing so, you should be able to raise a PR on the main repo 🙏

sshanzel avatar Sep 28 '25 07:09 sshanzel

Thank you, @sshanzel :)

Efury1 avatar Sep 29 '25 18:09 Efury1

Image

Hi, sorry for the back and forth. I've just forked and I am having an issue with Gitpod. I've screenshotted the issue above. Let me know if you have seen this before :)

Efury1 avatar Oct 05 '25 13:10 Efury1

Hi, sorry for the back and forth. I've just forked and I am having an issue with Gitpod. I've screenshotted the issue above. Let me know if you have seen this before :)

Hi. I haven't actually experienced this. Let me get back to you on this first thing tomorrow 🙏

sshanzel avatar Oct 13 '25 18:10 sshanzel

Hi @Efury1, sorry for all this, it seems that GitPod is about to sunset their Classic version, which used to not require these card verifications and such. Unfortunately, they will be sunsetting it tomorrow.

I will come up with an alternative for this over the weekend. Thank you for your patience.

sshanzel avatar Oct 14 '25 12:10 sshanzel

hey @sshanzel, any progress on getting around the required card verification?

rryyqn avatar Oct 21 '25 06:10 rryyqn

@sshanzel, thank you! I'll keep and eye on this ticket!

Efury1 avatar Oct 22 '25 10:10 Efury1

@Efury1 @rryyqn thank you for your patience 🙏 I have pushed some changes to allow local development. Kindly follow the steps below. I am updating the README on how to do it for future references.

Image

sshanzel avatar Nov 03 '25 03:11 sshanzel

can i work on this?

syu213 avatar Dec 07 '25 08:12 syu213

it's been a while since we heard from @Efury1 , so I'll you pick this up @syu213 :)

idoshamun avatar Dec 07 '25 08:12 idoshamun