🐛 BUG: Profile card popup opens automatically on focus (Accessibility)
What went wrong? 🤔
When navigating with the keyboard (Tab), moving focus onto a profile card automatically opens a popup without the user pressing Enter.
This breaks accessibility expectations and violates WCAG 2.1 – On Focus (3.2.1) , which states that elements should not trigger context changes on focus.
Expected Behavior
Expected Behavior
Focusing on the card should only highlight it.
The popup should not open automatically.
Personally, I think pressing Enter should open the profile page itself (not a preview popup).
That would be more consistent with accessibility best practices.
Otherwise, if a popup is kept, it would require capturing focus inside the popup and managing tab order properly, which makes things more complicated and less intuitive.
Steps to Reproduce Issue
Navigate the feed using Tab.
Focus on a profile card.
Observe that a popup opens automatically without activation.
Solution Proposed
-
Remove the onFocus trigger for the popup for tab
-
On enter open the full profile page directly, instead of a popup preview, to simplify focus handling and improve accessibility.
Screenshots
Image below shows card with tab focus
Environment
No response
Browsers
Chrome
OS
Windows
Version of daily.dev
Most recent version
Additional Context
Code of Conduct
- [x] I follow the conditions of this project.
Let me know your thoughts and if this is something you have thought about.
Hi @Efury1,
Great catch! We'd love to see it gets fixed if you wish to contribute.
Hi, I’d love to contribute! I’ll start looking into it today and will reach out if I have any questions about the codebase :)
Amazing!
@Efury1 feel free to head to our GitPod setup for local development! 🥳
@sshanzel Thank you, I've got it working on there now :D
I tried pushing my branch (fix/1949-profile-card-autofocus) but I’m getting this error:
$ git push -u origin fix/1949-profile-card-autofocus
remote: {"auth_status":"access_denied_to_user","body":"Permission to dailydotdev/daily.git denied to Efury1."}
fatal: unable to access 'https://github.com/dailydotdev/daily.git/': The requested URL returned error: 403
Has anyone else run into this issue before? And what did you do to fix it?
Hi @Efury1! For you to be able to raise a PR, you'll have to fork the repo, then push to a branch there. After doing so, you should be able to raise a PR on the main repo 🙏
Thank you, @sshanzel :)
Hi, sorry for the back and forth. I've just forked and I am having an issue with Gitpod. I've screenshotted the issue above. Let me know if you have seen this before :)
Hi, sorry for the back and forth. I've just forked and I am having an issue with Gitpod. I've screenshotted the issue above. Let me know if you have seen this before :)
Hi. I haven't actually experienced this. Let me get back to you on this first thing tomorrow 🙏
Hi @Efury1, sorry for all this, it seems that GitPod is about to sunset their Classic version, which used to not require these card verifications and such. Unfortunately, they will be sunsetting it tomorrow.
I will come up with an alternative for this over the weekend. Thank you for your patience.
hey @sshanzel, any progress on getting around the required card verification?
@sshanzel, thank you! I'll keep and eye on this ticket!
@Efury1 @rryyqn thank you for your patience 🙏 I have pushed some changes to allow local development. Kindly follow the steps below. I am updating the README on how to do it for future references.
can i work on this?
it's been a while since we heard from @Efury1 , so I'll you pick this up @syu213 :)