daily icon indicating copy to clipboard operation
daily copied to clipboard

🐛 BUG: Fix missing bottom margin in footer links when no comments are present

Open junaiddshaukat opened this issue 8 months ago • 4 comments

What went wrong? 🤔

I notice that in the webapp there is a footer layout issue when the post have no comments

Expected Behavior

  • The footer should have consistent spacing whether comments are present or not.

Steps to Reproduce Issue

1. Open a post **without any comments**.  
2. Scroll down to the footer section.  
3. Notice that the links do not have proper bottom spacing.

Solution Proposed

Proposed Fix

  • Ensure that the footer has a consistent bottom margin regardless of the presence of comments.

Screenshots

Image

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

- If the post has **comments**, this issue **does not occur** because the comment section naturally adds spacing.

Code of Conduct

  • [x] I follow the conditions of this project.

junaiddshaukat avatar Mar 26 '25 11:03 junaiddshaukat

Thanks for reporting this issue. We have accepted it and it will be fixed in the future. It is open for public contribution

sabdailydev avatar Mar 26 '25 14:03 sabdailydev

@sabdailydev I have created a PR in which I have fixed this issues. Here is the PR Link: https://github.com/dailydotdev/apps/pull/4310

junaiddshaukat avatar Mar 26 '25 14:03 junaiddshaukat

Thanks for reporting this issue. We have accepted it and it will be fixed in the future. It is open for public contribution

Can you review my PR for this issue: https://github.com/dailydotdev/apps/pull/4310

junaiddshaukat avatar Mar 26 '25 17:03 junaiddshaukat

@junaiddshaukat Thanks, the PR review is in the pipeline.

sabdailydev avatar Mar 27 '25 10:03 sabdailydev