dailydotdev
🐛 BUG: missing border radius on the card
What went wrong? 🤔
The card itself has a border-radius but the focus highlight does not display the same. It is likely due to some container or wrapper on the card that does not share the same border-radius.
Expected Behavior
Should have the same amount as the card.
Steps to Reproduce Issue
1. Go to the feed
2. Click on any post to open a modal
3. Click escape on your keyboard
4. See the issue
Solution Proposed
Share the same border-radius
Screenshots
Environment
No response
Browsers
No response
OS
No response
Version of daily.dev
No response
Additional Context
No response
Code of Conduct
- [X] I follow the conditions of this project.
@sshanzel I have checked and tried to fix the issue, please review the PR and merge https://github.com/dailydotdev/apps/pull/3574
@Ahmad-Zahid sorry I did not get the chance to reply to you last week. It looks though that @Ankita-Nandkumar-Patil has worked on it already, so let's see how it went 👀
Thank you both for the interest.
hey @sshanzel Thank you for assigning, please check the PR, and let me know if anything required further https://github.com/dailydotdev/apps/pull/3574
Is this still open?
Hello, yes, feel free to check it out if you like 🙌
This was fixed initially, but we had to revert the fix due to some issue, kindly check the PRs below:
- https://github.com/dailydotdev/apps/pull/3574
- https://github.com/dailydotdev/apps/pull/3593
@sshanzel i have fixed the issue, now it will only work for article cards. Please review #3662
@SuyashShukla0007 , nope it's solved . You can check it when running gitpod
Yeah, this should've been fixed a week ago by another OSS contributor as well.