apps icon indicating copy to clipboard operation
apps copied to clipboard

fix: dancing shortcut popup

Open Abhi-Bohora opened this issue 4 months ago • 1 comments

Changes

Linked Issue: (https://github.com/dailydotdev/daily/issues/1357)

Describe what this PR does

This pr aims to fix the shortcut link input box UI glitch in the extension of daily.dev as shown in the video in the linked issue whenever users try to input a shortcut link and enter an invalid URL the input box begins to glitch up and down infinitely. I think this was caused by an inconsistent state between valid and invalid URL caused by a delay in debounce so I have introduced an immediate validation check with no delay and jumping UI.

note: I have tested this only in Chrome I believe it should work for another browser extension too.

After changes

https://github.com/user-attachments/assets/d8259ba5-0708-458f-abdc-6f39c5bb8d6c

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

[!CAUTION] Please make sure existing components are not breaking/affected by this PR

Abhi-Bohora avatar Oct 21 '24 14:10 Abhi-Bohora