apps icon indicating copy to clipboard operation
apps copied to clipboard

chore: react package upgrade to v18

Open sshanzel opened this issue 8 months ago • 4 comments

Changes

  • Most of the changes were explained within the RFC. Those that were not, encountered on the actual upgrade, should be mentioned below.
  • When a useEffect returns a function, it should be consistent across all returns.
  • The callback for empty feed is now inline rather than having a useEffect.
  • Fixed some minor type issues.
    • Notable issue is that, usages of FunctionComponent or FC would now require to explicitly define thechildren property.
  • There have been numerous errors as well about:
    • Missing key on mapped render.
    • Some props that have been passed that are not necessary.
  • Migrated some usages of icon to be inline with how we normally do it.
  • The act function should now be coming from react package.

Describe what this PR does

  • Short and concise, bullet points can help
  • Screenshots if applicable can also help

Events

Did you introduce any new tracking events? Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • [x] Have you done sanity checks in the webapp?
  • [x] Have you done sanity checks in the extension?
  • [x] Does this not break anything in companion?

Did you test the modified components media queries?

  • [x] MobileL (420px)
  • [x] Tablet (656px)
  • [x] Laptop (1020px)

Did you test on actual mobile devices?

  • [ ] iOS (Chrome and Safari)
  • [ ] Android

WT-{number} #done

Preview domain

https://mi-391.preview.app.daily.dev

sshanzel avatar Jun 26 '24 02:06 sshanzel