apps icon indicating copy to clipboard operation
apps copied to clipboard

fix: change onCloseModal hook in usePostModalNavigation.ts

Open ParthTyagi15 opened this issue 8 months ago • 1 comments

Changes

  • changed the onCloseModal hook in usePostModalNavigation.ts
  • Now when the user closes the modal by clicking on any area outside the modal, the navigation works fine.
  • There was one extra redundant history being pushed on closing the modal(specifically by clicking outside) which caused the issue.

Describe what this PR does

  • fixes the issue mentioned here: https://github.com/dailydotdev/daily/issues/1216

Events

Did you introduce any new tracking events? Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • [ ] Have you done sanity checks in the webapp?
  • [ ] Have you done sanity checks in the extension?
  • [ ] Does this not break anything in companion?

Did you test the modified components media queries?

  • [ ] MobileL (420px)
  • [ ] Tablet (656px)
  • [ ] Laptop (1020px)

Did you test on actual mobile devices?

  • [ ] iOS (Chrome and Safari)
  • [ ] Android

WT-{number} #done

ParthTyagi15 avatar Jun 23 '24 19:06 ParthTyagi15