apps icon indicating copy to clipboard operation
apps copied to clipboard

Lint config for checking typos in the code

Open xnivaxhzne opened this issue 1 year ago • 4 comments

Changes

Describe what this PR does

This PR is created in response for this comment by @rebelchris This PR adds a new lint script to check for typos in the code. This lint script will be part of pretest script. This also fixes a typo in the code.

Events

Did you introduce any new tracking events? Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • [x] Have you done sanity checks in the webapp?
  • [x] Have you done sanity checks in the extension?
  • [x] Does this not break anything in companion?

Did you test the modified components media queries?

  • [ ] MobileL (420px)
  • [ ] Tablet (656px)
  • [ ] Laptop (1020px)

Did you test on actual mobile devices?

  • [ ] iOS (Chrome and Safari)
  • [ ] Android

WT-{number} #done

xnivaxhzne avatar Aug 22 '23 14:08 xnivaxhzne

Thank you for the initiative! Would it be possible for you to check the eslint plugin relevant to this?

sshanzel avatar Aug 29 '23 07:08 sshanzel

Thank you for the initiative! Would it be possible for you to check the eslint plugin relevant to this?

@sshanzel After my analysis, found that there is an es-lint plugin for that.

But, as mentioned here, the underlying implementation to parse and check the spelling are different. Because of that, we have lot of limitations in the eslint plugin. I have tried it in my local.

One of them is, it cannot check for compound words, whereas the core package allows us to do it.

Anyway, requested for clarification in the respective repo. Will wait and confirm the same here.

xnivaxhzne avatar Aug 29 '23 14:08 xnivaxhzne

Thank you for the initiative! Would it be possible for you to check the eslint plugin relevant to this?

@sshanzel After my analysis, found that there is an es-lint plugin for that.

But, as mentioned here, the underlying implementation to parse and check the spelling are different. Because of that, we have lot of limitations in the eslint plugin. I have tried it in my local.

One of them is, it cannot check for compound words, whereas the core package allows us to do it.

Anyway, requested for clarification in the respective repo. Will wait and confirm the same here.

Thank you very much for connecting with the plugin team, from their response, it seems compound words are allowed. Let me know if you are still interested in this PR. Else, we can close this one. With that, we appreciate the time and effort you've spent here 🙏

sshanzel avatar Oct 05 '23 07:10 sshanzel

Thank you for the initiative! Would it be possible for you to check the eslint plugin relevant to this?

@sshanzel After my analysis, found that there is an es-lint plugin for that. But, as mentioned here, the underlying implementation to parse and check the spelling are different. Because of that, we have lot of limitations in the eslint plugin. I have tried it in my local. One of them is, it cannot check for compound words, whereas the core package allows us to do it. Anyway, requested for clarification in the respective repo. Will wait and confirm the same here.

Thank you very much for connecting with the plugin team, from their response, it seems compound words are allowed. Let me know if you are still interested in this PR. Else, we can close this one. With that, we appreciate the time and effort you've spent here 🙏

@sshanzel let me check and do an update in sometime. Thank you.

xnivaxhzne avatar Oct 05 '23 17:10 xnivaxhzne

Closing since there hasn't been any movement on this end. Thank you for the effort 🙏

sshanzel avatar Apr 04 '24 09:04 sshanzel