meow
meow copied to clipboard
chore(deps): update dependency urllib3 to v2.2.2 [security]
This PR contains the following updates:
Package | Change | Age | Adoption | Passing | Confidence |
---|---|---|---|---|---|
urllib3 (changelog) | ==2.0.4 -> ==2.2.2 |
GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the Cookie
HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a Cookie
header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.
Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the Cookie
header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.
Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
- Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6)
- Using the
Cookie
header on requests, which is mostly typical for impersonating a browser. - Not disabling HTTP redirects
- Either not using HTTPS or for the origin server to redirect to a malicious origin.
Remediation
- Upgrading to at least urllib3 v1.26.17 or v2.0.6
- Disabling HTTP redirects using
redirects=False
when sending requests. - Not using the
Cookie
header.
CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST
) to GET
as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.
From RFC 9110 Section 9.3.1:
A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
- If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
- The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.
Remediation
You can remediate this vulnerability with any of the following steps:
- Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
- Disable redirects for services that you aren't expecting to respond with redirects with
redirects=False
. - Disable automatic redirects with
redirects=False
and handle 303 redirects manually by stripping the HTTP request body.
CVE-2024-37891
When using urllib3's proxy support with ProxyManager
, the Proxy-Authorization
header is only sent to the configured proxy, as expected.
However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the Proxy-Authorization
header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the Proxy-Authorization
HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.
Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the Proxy-Authorization
header during cross-origin redirects to avoid the small chance that users are doing this on accident.
Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the Proxy-Authorization
header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.
Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
- Setting the
Proxy-Authorization
header without using urllib3's built-in proxy support. - Not disabling HTTP redirects.
- Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin.
Remediation
- Using the
Proxy-Authorization
header with urllib3'sProxyManager
. - Disabling HTTP redirects using
redirects=False
when sending requests. - Not using the
Proxy-Authorization
header.
Release Notes
urllib3/urllib3 (urllib3)
v2.2.2
==================
- Added the
Proxy-Authorization
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
. - Allowed passing negative integers as
amt
to read methods ofhttp.client.HTTPResponse
as an alternative toNone
. (#​3122 <https://github.com/urllib3/urllib3/issues/3122>
__) - Fixed return types representing copying actions to use
typing.Self
. (#​3363 <https://github.com/urllib3/urllib3/issues/3363>
__)
v2.2.1
==================
- Fixed issue where
InsecureRequestWarning
was emitted for HTTPS connections when using Emscripten. (#​3331 <https://github.com/urllib3/urllib3/issues/3331>
__) - Fixed
HTTPConnectionPool.urlopen
to stop automatically casting non-proxy headers toHTTPHeaderDict
. This change was premature as it did not apply to proxy headers andHTTPHeaderDict
does not handle byte header values correctly yet. (#​3343 <https://github.com/urllib3/urllib3/issues/3343>
__) - Changed
InvalidChunkLength
toProtocolError
when response terminates before the chunk length is sent. (#​2860 <https://github.com/urllib3/urllib3/issues/2860>
__) - Changed
ProtocolError
to be more verbose on incomplete reads with excess content. (#​3261 <https://github.com/urllib3/urllib3/issues/3261>
__)
v2.2.0
==================
- Added support for
Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html>
, including streaming support in cross-origin isolated browser environments where threading is enabled. (#​2951 <https://github.com/urllib3/urllib3/issues/2951>
) - Added support for
HTTPResponse.read1()
method. (#​3186 <https://github.com/urllib3/urllib3/issues/3186>
__) - Added rudimentary support for HTTP/2. (
#​3284 <https://github.com/urllib3/urllib3/issues/3284>
__) - Fixed issue where requests against urls with trailing dots were failing due to SSL errors
when using proxy. (
#​2244 <https://github.com/urllib3/urllib3/issues/2244>
__) - Fixed
HTTPConnection.proxy_is_verified
andHTTPSConnection.proxy_is_verified
to be always set to a boolean after connecting to a proxy. It could beNone
in some cases previously. (#​3130 <https://github.com/urllib3/urllib3/issues/3130>
__) - Fixed an issue where
headers
passed in a request withjson=
would be mutated (#​3203 <https://github.com/urllib3/urllib3/issues/3203>
__) - Fixed
HTTPSConnection.is_verified
to be set toFalse
when connecting from a HTTPS proxy to an HTTP target. It was set toTrue
previously. (#​3267 <https://github.com/urllib3/urllib3/issues/3267>
__) - Fixed handling of new error message from OpenSSL 3.2.0 when configuring an HTTP proxy as HTTPS (
#​3268 <https://github.com/urllib3/urllib3/issues/3268>
__) - Fixed TLS 1.3 post-handshake auth when the server certificate validation is disabled (
#​3325 <https://github.com/urllib3/urllib3/issues/3325>
__) - Note for downstream distributors: To run integration tests, you now need to run the tests a second
time with the
--integration
pytest flag. (#​3181 <https://github.com/urllib3/urllib3/issues/3181>
__)
v2.1.0
==================
Read the v2 migration guide <https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html>
__ for help upgrading to the latest version of urllib3.
Removals
- Removed support for the deprecated urllib3[secure] extra. (
#​2680 <https://github.com/urllib3/urllib3/issues/2680>
__) - Removed support for the deprecated SecureTransport TLS implementation. (
#​2681 <https://github.com/urllib3/urllib3/issues/2681>
__) - Removed support for the end-of-life Python 3.7. (
#​3143 <https://github.com/urllib3/urllib3/issues/3143>
__)
Bugfixes
- Allowed loading CA certificates from memory for proxies. (
#​3065 <https://github.com/urllib3/urllib3/issues/3065>
__) - Fixed decoding Gzip-encoded responses which specified
x-gzip
content-encoding. (#​3174 <https://github.com/urllib3/urllib3/issues/3174>
__)
v2.0.7
==================
- Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.
v2.0.6
==================
- Added the
Cookie
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
.
v2.0.5
==================
- Allowed pyOpenSSL third-party module without any deprecation warning. (
#​3126 <https://github.com/urllib3/urllib3/issues/3126>
__) - Fixed default
blocksize
ofHTTPConnection
classes to match high-level classes. Previously was 8KiB, now 16KiB. (#​3066 <https://github.com/urllib3/urllib3/issues/3066>
__)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.