phyr icon indicating copy to clipboard operation
phyr copied to clipboard

Published 20 hours ago • verified publisher icon daijiang

binaryPGLMM

Open arives opened this issue 6 years ago • 2 comments

I figure we should update binaryPGLMM to do family=binomial and poisson. Should we change the name? This has the advantage of differentiating it from binaryPGLMM in ape, which we've talked about. How about calling it PGLMM?

I can also update rr2 to swap binaryPGLMM for PGLMM. But should I include a version of PGLMM in rr2 because rr2 will likely precede phyr? PGLMM is more complicated than rr2, which doesn't involve C++. I could just put the R version of PGLMM on rr2.

Thoughts?

arives avatar Oct 07 '18 10:10 arives

Hi Tony, It would be great to update the version in rr2 first, then I can update phyr accordingly. Plus, the c++ part of binaryPGLMM does not take effect yet.

I just made pglmm as an alias for communityPGLMM. Can we think another name for binaryPGLMM? Maybe something like pglm?

Best, Daijiang

daijiang avatar Oct 07 '18 15:10 daijiang

Daijiang,

Great. I’ll update the R version in rr2. As for names, I’d forgotten about pglmm for communityPGLMM. Maybe discretePGLMM. What do you think?

This did make me think about pglmm again. For that name, it probably does make sense to have it set up in a form where, at least for the long form specification, the factors don’t need to be called sp and site.

Cheers, Tony

From: Daijiang Li [email protected] Reply-To: daijiang/phyr [email protected] Date: Sunday, October 7, 2018 at 10:12 AM To: daijiang/phyr [email protected] Cc: "Anthony R. Ives" [email protected], Author [email protected] Subject: Re: [daijiang/phyr] binaryPGLMM (#28)

Hi Tony, It would be great to update the version in rr2 first, then I can update phyr accordingly. Plus, the c++ part of binaryPGLMM does not take effect yet.

I just made pglmm as an alias for communityPGLMM. Can we think another name for binaryPGLMM? Maybe something like pglm?

Best, Daijiang

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/daijiang/phyr/issues/28#issuecomment-427660693, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALF_LFftbwMVjRDvXURrFZjmnzl3ARzGks5uihnHgaJpZM4XLx0L.

arives avatar Oct 07 '18 15:10 arives