EmptyEpsilon icon indicating copy to clipboard operation
EmptyEpsilon copied to clipboard

Automatic update check

Open hemmond opened this issue 4 years ago • 7 comments
trafficstars

@gcask have shown install wizzard for Windows version of Empty Epsilon. I recommend to enhance it further with automatic update check and notification (only in versions where it makes sense).

For me it makes sense:

  • in installed Windows version
  • in .deb package which is manually installed (without repository)

For me it does not make sense:

  • in extracted .zip file (when I use zip file, I usually know what version I am running and why this version).
  • in repository-managed packages (I know EE is in Fedora's RPMFusion repository and in Arch Linux package repositories)

This issue is for discussion on how this facility should be implemented so it is not annoying, yet it serves users well. Version mismatch on online events can be a big problem even for other clients, which have correct version.

hemmond avatar Mar 22 '21 22:03 hemmond

It's relatively easy to check if there is a newer version: https://api.github.com/repos/daid/emptyepsilon/releases/latest

daid avatar Mar 22 '21 22:03 daid

Exactly.

I would shove the check behind a preference settings and default it to true.

Package managers are then free to change it to what matches best their respective platform policies.

And if you're bothered by it just disable it from the ini (or the options if you feel like adding a binding there).

gcask avatar Mar 22 '21 23:03 gcask

And I think I would preferrer to have this very uninvasive. Like just a box in the corner of the main menu saying [Newer version available: XXXX-XX-XX]

daid avatar Mar 23 '21 08:03 daid

I also prefer uninvasive, but on the other hand, it should be noticed by user. Maybe red notice under version number?

hemmond avatar Mar 23 '21 12:03 hemmond

I think I prefer @daid 's, something like that maybe? image

(don't get too excited, that's just a mock up done in paint.net)

gcask avatar Mar 26 '21 13:03 gcask

yeah, something like that. People could have a good reason to run older versions, so making it non intrusive is important IMHO.

daid avatar Mar 27 '21 17:03 daid

I don't like this implementation, which also requires a change to SeriousProton to send a User-Agent header in the request (otherwise GitHub forbids it): https://gist.github.com/oznogon/c7dce727388abead734c7b0284e0a4b6

But it shows that we can poll the GitHub API with sp::io::http::Request, parse with sp::json::parse, compare with VERSION_NUMBER, and flag it in the log and main menu.

image

oznogon avatar Jan 16 '23 21:01 oznogon