fluent-plugin-gcs icon indicating copy to clipboard operation
fluent-plugin-gcs copied to clipboard

Published 20 hours ago • verified publisher icon daichirata

Change recursion to loop in generate_path

Open sfc-gh-cxu opened this issue 4 years ago • 2 comments

Iterative implementation for generate_path() will reduce the risk of stack overflow due to recursion. This change could mitigate https://github.com/daichirata/fluent-plugin-gcs/issues/17.

I new to Ruby and have some trouble with the unit test failures... @daichirata @cosmo0920 could you help me take a look?

sfc-gh-cxu avatar Feb 03 '21 10:02 sfc-gh-cxu

@daichirata @cosmo0920 Pardon me for another ping. Could you take a look at this PR and perhaps share some guidance on how to fix the test? Thank you so much

sfc-gh-cxu avatar Apr 30 '21 07:04 sfc-gh-cxu

Is there anyway to get this pr addressed. Anything I can do to help?

This issue is causing my team much pain. =(

RoyTrudell avatar Nov 15 '22 19:11 RoyTrudell

Since it was not possible to import the file as is due to a bug, we fixed the bug and merged the file after cherry-picking it.

  • #24

daichirata avatar Sep 19 '23 08:09 daichirata