rustis icon indicating copy to clipboard operation
rustis copied to clipboard

[Bug] Unsubscribe on drop implementation causes a panic when receiving malformed response?

Open CR7273868 opened this issue 10 months ago • 3 comments

3|tracker_ | thread 'tokio-runtime-worker' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustis-0.12.9/src/network/network_handler.rs:545:17: 3|tracker_ | [private:6379] Received unexpected message: Ok(Push([BulkString("unsubscribe"), BulkString("tracker:346240269"), Integer(0)])) 3|tracker_ | note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Info is somehow limited it seems to be coming from the rustis library itself? It's on 0.12.8.

CR7273868 avatar Apr 04 '24 04:04 CR7273868

Hello,

Thank you for the report. Could you provide a sample please?

When you write "unsubscribe on drop implementation". Do you mean a PubSubStream has been dropped or something else ?

Thank you,

Michaël

mcatanzariti avatar Apr 06 '24 06:04 mcatanzariti

Hello,

I just fixed a bad status pb in the NetworkHandler implementation, let me know if it fixes your pb. https://github.com/dahomey-technologies/rustis/commit/b107cdbdfd1c553edf5a55ff81f63aea7dbcd662

mcatanzariti avatar Apr 06 '24 18:04 mcatanzariti

any news ?

mcatanzariti avatar Apr 18 '24 13:04 mcatanzariti

new fix on release 0.13.3.

Could you test it, please?

mcatanzariti avatar May 28 '24 20:05 mcatanzariti

Hi,

I close this bug as stalled. Please feel free to reopen it if you encounter any additional issue!

mcatanzariti avatar Jun 09 '24 12:06 mcatanzariti