Hong Minhee (洪 民憙)

Results 157 issues of Hong Minhee (洪 民憙)

States have been intended to be nullable, as they can be empty. I believe the nullability on that parameter was missing when I added `#nullable enable` to the source file....

bug
stale

`MerkleTrie`, the only implementation of `ITrie` as of now, is less freedom of improvement due to the already running mainnet of *Nine Chronicles*. In order to improve Libplanet's own MPT...

suggestion
discussion needed
stale
storage

There are methods doing the similar thing in several places: - *Libplanet.Extensions.Cocona*: [`StatsCommand.LoadStoreFromUri()`](https://github.com/planetarium/libplanet/blob/0.19.1/Libplanet.Extensions.Cocona/Commands/StatsCommand.cs#L100-L129) method - *Libplanet.Extensions.Cocona*: [`StoreCommand.LoadStoreFromUri()`](https://github.com/planetarium/libplanet/blob/0.19.1/Libplanet.Extensions.Cocona/Commands/StoreCommand.cs#L206-L235) method - *Libplanet.Explorer.Executable*: [`Program.LoadStore()`](https://github.com/planetarium/libplanet/blob/0.19.1/Libplanet.Explorer.Executable/Program.cs#L280-L341) method What they do is to instantiate an implementation...

stale
storage
tools
explorer
api

Related: #1146. To be elaborated.

discussion needed
stale

Historically, at the very beginning, we had `Transaction.Sender`–`Transaction.Recipient` model, which was made after Bitcoin's or Ethereum's cryptocurrency model. In 0.2 release, we became to need “multiple recipients” because Libplanet is...

suggestion
stale
storage

> Can we clarify it's use a bit more? > > As I understand it, seems like this is to "group" `UntypedTransaction` and `Transaction` for validating nonces. In any case,...

stale
api

- [ ] `IterateTransactionIds()` - [ ] `DeleteTransaction()` - [ ] `CountTransactions()`

help wanted
storage

``` Assert.Equal() Failure Expected: 17 Actual: 14 at Libplanet.Tests.Blockchain.Renderers.DelayedActionRendererTest+d__6.MoveNext () [0x004b6] in /mnt/ramdisk/Libplanet.Tests/Blockchain/Renderers/DelayedActionRendererTest.cs:500 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c]...

bug
ci & cd

So that minters cannot mint money at their will.

suggestion

> It will be great if we can remove this and make `Libplanet` internals used in `Libplanet.Net` public. > > _Originally posted by @limebell in https://github.com/planetarium/libplanet/pull/1760#discussion_r792261018_ Currently *Libplanet* allows *Libplanet.Net*...

good first issue
stale