Hong Minhee (洪 民憙)

Results 191 comments of Hong Minhee (洪 民憙)

Invoking `py.test` (without any arguments) must simply work. Did you happen to run tests in `tests/` directory? It should be run at root of the source tree.

I just noticed that the error type is not `ImportError` but `ValueError`. Can I see the more detailed trackback? Try `-vv` option.

Could you paste the output of `tree` command from root of the source tree as well?

That’s indeed problematic, so I will include these missing files as well. Thanks!

Hmm… your code does not reproduce the bug in both CPython 2.7.15 and 3.7.4 on macOS. What's your OS and Python version?

As I currently have no Windows box, it's difficult to reproduce this bug for me. 😥 It would be great if you send a patch to fix this.

If diffs become longer it would be harder to review for me… Some touches on style would be fine though.

Yeah, it must be helpful we have any types of automated tests; unit tests or functional tests, whatever. Could anybody help?

@mvrozanti Sorry for my late response. As @daturkel explained, it was an error that [has existed before changes you made][1], and I finally [fixed][2] the error in the master. The...

I'm pessimistic about composability/compatibility between TUI frameworks and `fzf`, but if someone are willing to make it that would be great.