dagster icon indicating copy to clipboard operation
dagster copied to clipboard

[dagit] Workspace Overview page

Open hellendag opened this issue 2 years ago • 2 comments

Summary & Motivation

Create a new Workspace overview page, currently behind a flag. The page shows all loaded repositories in a grid of cards, with a bit of metadata about each repo. Click through to a repo will lead to the new virtualized table views.

Because we will now show virtualized tables for single repos, the collapsible repo sections and repo filter button are removed.

Screen Shot 2022-09-20 at 2 15 40 PM Screen Shot 2022-09-20 at 2 15 51 PM

How I Tested These Changes

Enable new workspace page flag, click "Workspace" nav item. Verify card rendering. Shrink viewport to verify card resizing and wrapping, hover on cards to verify styles. Click into a repo, then click Jobs tab. Verify that Jobs, Schedules, and Sensors all load correctly.

hellendag avatar Sep 20 '22 19:09 hellendag

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Sep 21, 2022 at 2:03PM (UTC)
dagster ⬜️ Ignored (Inspect) Sep 21, 2022 at 2:03PM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Sep 21, 2022 at 2:03PM (UTC)

vercel[bot] avatar Sep 20 '22 19:09 vercel[bot]

Current dependencies on/for this PR:

  • master
    • PR #9744 Graphite 👈
      • PR #9759 Graphite

This comment was auto-generated by Graphite.

hellendag avatar Sep 20 '22 19:09 hellendag

If someone only has one repo, is it annoying to see the new root page with one card? Should we auto-redirect into the workspace views?

I think that would be sensible, though they would then miss out on the "Recently viewed" feature we're also planning to have here. What do you think @braunjj?

If you're viewing one of these repo pages, any buttons that let you reload the repo (is there one, actually? Maybe there should be...) might have an awkward new behavior where if the reload fails the repo location exists but the repo no longer does, you could be looking at a 404 page? We might need to test the reload flow a bit.

I haven't put a button on there yet, but I think it would be a good idea. I think the failure case you describe might already be a problem on any repo permalink (for jobs, etc.) where you reload and the whole repo is gone...

hellendag avatar Sep 22 '22 15:09 hellendag

I think it makes sense to redirect to the repo if there's only one for now at least. Once we start to implement more features or add more content at the root level we can always show it.

In the case of reloading the workspace and having the repository disappear, it might be cool to just redirect users to the workspace root page.

braunjj avatar Sep 22 '22 15:09 braunjj