dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Consolidate resource / instance logic for invocation

Open dpeng817 opened this issue 2 years ago • 2 comments

Summary & Motivation

Consolidates the logic used to open resource-based context managers for direct invocation of dagster definitions. Also fixes https://github.com/dagster-io/dagster/issues/9362

How I Tested These Changes

Existing unit tests + ensuring that the repro in linked issue does not result in an error.

dpeng817 avatar Aug 29 '22 23:08 dpeng817

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Oct 28, 2022 at 9:03PM (UTC)
dagster ⬜️ Ignored (Inspect) Oct 28, 2022 at 9:03PM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Oct 28, 2022 at 9:03PM (UTC)

vercel[bot] avatar Aug 29 '22 23:08 vercel[bot]

Current dependencies on/for this PR:

  • master
    • PR #9535 Graphite 👈

This comment was auto-generated by Graphite.

dpeng817 avatar Aug 29 '22 23:08 dpeng817

Hey @dpeng817 does this still need review/is up to date? Pretty stale.

schrockn avatar Nov 22 '22 15:11 schrockn