dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Unpin google dependencies

Open amarrella opened this issue 2 years ago • 3 comments

Summary & Motivation

Fixes https://github.com/dagster-io/dagster/issues/4748

How I Tested These Changes

I installed dagster in my local env (thanks for the Contributing guide!) and ran

python -m pytest python_modules/libraries/dagster-gcp/dagster_gcp_tests

The only errors i got were access error because i couldn't read the gcs bucket.

Let me know if something else needs to be tested! (I don't use dataproc though so that would be the hardest to test for me)

amarrella avatar Aug 09 '22 19:08 amarrella

@amarrella is attempting to deploy a commit to the Elementl Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 09 '22 19:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Oct 10, 2022 at 8:33PM (UTC)
dagster ⬜️ Ignored (Inspect) Oct 10, 2022 at 8:33PM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Oct 10, 2022 at 8:33PM (UTC)

vercel[bot] avatar Aug 09 '22 19:08 vercel[bot]

@rexledesma saw that you added the original diff that pinned google-api-python-client, mind taking a look at this?

clairelin135 avatar Aug 09 '22 20:08 clairelin135

Hi @clairelin135 @rexledesma is there anything I can do to help this PR getting merged? These pins are holding us back on several dependencies

amarrella avatar Oct 05 '22 13:10 amarrella

@amarrella sorry about the late response! This is looking good to me, I've gone ahead and merged this now

clairelin135 avatar Oct 10 '22 20:10 clairelin135

No problem, thanks for taking care of this!

amarrella avatar Oct 11 '22 10:10 amarrella