dagster icon indicating copy to clipboard operation
dagster copied to clipboard

feat(helm): add job_namespace config to CeleryK8sExecutor

Open gmontanola opened this issue 1 year ago • 3 comments

Summary & Motivation

This can be defined in K8sRunLauncher parameters and setting this via Helm chart for Celery runs would be great.

Were there any issues not allowing this to happen before?

How I Tested These Changes

I haven't for now but I can test this with minikube locally. I followed the YAML trail and looks like this can work.

gmontanola avatar Aug 05 '22 02:08 gmontanola

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
dagit-storybook ⬜️ Ignored (Inspect) Aug 5, 2022 at 2:58AM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Aug 5, 2022 at 2:58AM (UTC)

vercel[bot] avatar Aug 05 '22 02:08 vercel[bot]

@gmontanola is attempting to deploy a commit to the Elementl Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 05 '22 02:08 vercel[bot]

Oh well, minutes after 1.0.0

If it's not possible to merge this, I think this will do.

A default_executor_def argument has been added to the @repository decorator. If specified, this will be used for any jobs (asset or op) which do not explicitly set an executor_def

gmontanola avatar Aug 05 '22 03:08 gmontanola

Hello, is someone willing to take a look at this PR? It is really annoying that new users need to add this setting to the configuration every time, causing unnecessary failed runs.

Thanks!

Milias avatar Mar 07 '23 19:03 Milias

Sorry for the long delay here - there are some more substantial changes that would need to be made to support this, which are in https://github.com/dagster-io/dagster/pull/12911 - thanks for sending this out nonetheless!

gibsondan avatar Mar 12 '23 18:03 gibsondan