dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Add pyright typecheck and coverage steps to BK

Open smackesey opened this issue 3 years ago • 2 comments

Summary & Motivation

This adds pyright typecheck and coverage steps to BK. They are disabled by default. Eventually, we should replace our mypy typecheck step with the pyright coverage step-- pyright is simply better, with far fewer bugs, better editor integration, better performance, and extremely responsive developers. We can't transition yet because pyright is also more sensitive than mypy and most of our code does not pass.

The type coverage step can be introduced sooner-- it checks whether the public API is fully typed. We are already at this standard with dagster core and will soon be with extension libs.

How I Tested These Changes

BK

smackesey avatar Jul 30 '22 00:07 smackesey

Current dependencies on/for this PR:

  • master
    • PR #9095 Graphite
      • PR #8733 Graphite
        • PR #9013 Graphite
          • PR #10496 Graphite
            • PR #10489 Graphite
              • PR #9113 Graphite 👈
              • PR #10712 Graphite
              • PR #10756 Graphite
                • PR #12245 Graphite

This comment was auto-generated by Graphite.

smackesey avatar Jul 30 '22 00:07 smackesey

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Nov 28, 2022 at 5:12PM (UTC)
dagster ⬜️ Ignored (Inspect) Nov 28, 2022 at 5:12PM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Nov 28, 2022 at 5:12PM (UTC)

vercel[bot] avatar Jul 30 '22 00:07 vercel[bot]