dagster icon indicating copy to clipboard operation
dagster copied to clipboard

respect repository namespace in schedule & sensor idempotence checks

Open alangenfeld opened this issue 2 years ago • 4 comments

if a user has multiple copies of the same schedule running in different repos at the same time, a run in one will prevent the other from firing.

How I Tested These Changes

added tests that previously failed

alangenfeld avatar Jul 28 '22 20:07 alangenfeld

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Aug 9, 2022 at 9:06PM (UTC)
dagster ⬜️ Ignored (Inspect) Aug 9, 2022 at 9:06PM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Aug 9, 2022 at 9:06PM (UTC)

vercel[bot] avatar Jul 28 '22 20:07 vercel[bot]

Current dependencies on/for this PR:

  • master
    • PR #9082 Graphite 👈

This comment was auto-generated by Graphite.

alangenfeld avatar Jul 28 '22 20:07 alangenfeld

I'd feel a whole lot better about this change (especially with the run key tag change) if we added some tests.

prha avatar Jul 28 '22 20:07 prha

Specifically, using list values for tags in combination with non-list values for tags.

prha avatar Jul 28 '22 20:07 prha