dagster icon indicating copy to clipboard operation
dagster copied to clipboard

[ui] Use RunFeed table for all remaining Runs views

Open bengotow opened this issue 1 year ago • 1 comments

Summary & Motivation

This PR swaps out the old RunTable for the new RunFeedTable for users with the new runs feed feature flag:

  • On the sensor page
  • On the schedule page
  • On the global AMP page and the AMP sensor page
  • On the Asset > Auto-materialize page [note: it now has checkboxes and the Actions button]
  • On the job runs page

Cleanup:

I moved a bunch of existing stuff into smaller files to re-use it and there aren’t significant changes in these files:

  • <RunsFeedError />
  • <PipelineRunsEmptyState/>
  • useIncludeRunsFromBackfillsOption
  • useRunsFeedEntries

One sidenote is that I kept a separate top level component for PipelineRunFeedRoot instead of trying to unify it with the global runs root, mostly because the global one has tabs, and the run-scoped one has “locked” tags. They are /just/ different enough that I think composition is better than a bunch of props turning things on and off. The other pages (eg: sensor, schedule runs) all use a new <RunsFeedTableWithFilters />

How I Tested These Changes

I took screenshots before and after of each impacted page to verify there weren't unintended changes, etc. However, there are a few places where an additional column is present in the new UI because our old tables were inconsistent. I think this is preferable and run tables should look the same everywhere, but I'll confirm with @braunjj.

Job Runs Page

Before: Screenshot 2024-10-13 at 11 12 40 PM

After: Screenshot 2024-10-13 at 11 12 53 PM

Asset Automation Page

Before: Screenshot 2024-10-13 at 11 12 11 PM

After: Screenshot 2024-10-13 at 11 12 02 PM

Sensor Runs Page:

Before Screenshot 2024-10-13 at 11 11 40 PM

After Screenshot 2024-10-13 at 11 11 26 PM

Schedule Page:

Before: Screenshot 2024-10-13 at 11 10 52 PM

After: Screenshot 2024-10-13 at 11 10 39 PM

bengotow avatar Oct 14 '24 04:10 bengotow

Deploy preview for dagit-core-storybook ready!

✅ Preview https://dagit-core-storybook-4uysbrnsx-elementl.vercel.app https://bengotow-2024-10-FE-515-2.core-storybook.dagster-docs.io

Built with commit a6a13c22be914e3e644d52749580fd5b52ef1101. This pull request is being automatically deployed with vercel-action

github-actions[bot] avatar Oct 14 '24 04:10 github-actions[bot]