Prevent accidental escape and clearing on Launchpad UI if a change is made

[cody-scott]

What's the use case?

Pressing the escape key when in the launchpad UI immediately closes and wipes the config. If anything has been typed in the launchpad it is immediately wiped and cannot be recovered without retyping.

Ideas of implementation

When a user inputs into the launch pad either flag the input as dirty, providing an alert prior to closing, or store the current config in a cache when on the same page so a user can reopen if closed, clearing cache after navigating to a new page.

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

[krukowski]

Internal tracking link: https://linear.app/dagster-labs/issue/FE-619/prevent-accidental-escape-and-clearing-on-launchpad-ui-if-a-change-is

[riziles]

@krukowski , It looks like this change has already been merged, but this is in direct conflict with ARIA guidelines:

https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/#keyboardinteraction

... also, there is no cancel button, so as far as I can tell there is NO way to close the modal without a mouse. This seems like a pretty big accessibility issue.

How about a "Are you sure you want to close?" prompt if the user hits escape?

[krukowski]

Thanks for flagging @riziles! We'll review those suggestions with the team shortly and likely open up a separate issue once we've had a chance to consider the scope of it.

For now though, I'm marking this issue as closed since the original report's been addressed.