dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Incorrect imports in wandb integration

Open slopp opened this issue 5 months ago • 2 comments

Dagster version

1.8.12

What's the issue?

One of the current examples for the weights and bias integration fails with: AttributeError: 'function' object has no attribute 'create_and_run_agent'

The code in question is: https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-wandb/dagster_wandb/launch/ops.py#L82

But in recent versions of the wandb sdk, launch is a function not a class, so we should be importing and using the create agent function directly: https://github.com/wandb/wandb/blob/main/wandb/sdk/launch/_launch.py#L141

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

slopp avatar Sep 25 '24 13:09 slopp