dagster icon indicating copy to clipboard operation
dagster copied to clipboard
verified publisher icon dagster-io

[DS][45/n] Create RequestedPreviousTickCondition

Open OwenKephart opened this issue 1 year ago • 1 comments

Summary & Motivation

As title -- also updated the name "RequestedThisTick" to "WillBeRequested".

If you're curious to get into the weeds on that decision, the next stack creates a "NewlyUpdated" condition, and so naming this new one "NewlyRequested" feels nice an symmetric, and "WillBeRequested" has better symmetry with "NewlyRequested" than "RequestedThisTick".

How I Tested These Changes

OwenKephart avatar May 20 '24 16:05 OwenKephart

  • #21975 Graphite: 2 dependent PRs (#21989 Graphite, #22048 Graphite)
  • #22058 Graphite
  • #21974 Graphite
  • #21973 Graphite
  • #21972 Graphite 👈
  • #21971 Graphite
  • #21853 Graphite: 1 other dependent PR (#21854 Graphite)
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

OwenKephart avatar May 20 '24 16:05 OwenKephart

What is the use case for detecting the previous tick only?

schrockn avatar May 30 '24 14:05 schrockn

Merge activity

  • Jun 4, 9:49 AM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • Jun 4, 9:56 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 4, 9:57 AM EDT: @OwenKephart merged this pull request with Graphite.

OwenKephart avatar Jun 04 '24 13:06 OwenKephart