dagster icon indicating copy to clipboard operation
dagster copied to clipboard

[dagster-graphql] Add method for terminating job runs to DagsterGraphQLClient

Open garethbrickman opened this issue 9 months ago • 4 comments

What's the use case?

The GraphQL API itself has a ​terminateRun​ mutation ­documented here as well as a terminateRuns mutation that can take multiple Run IDs.

Both of these should be supported in the GraphQL Python Client.

Ideas of implementation

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

garethbrickman avatar May 07 '24 17:05 garethbrickman

Hello @garethbrickman

Just to clarify the required enhancements: The function terminate_run already exists in the client, as seen here: terminate_run function.

Would you like to add a terminate_runs function to the client that can handle multiple Run IDs simultaneously, similar to the terminateRuns mutation in the GraphQL API? If so, I'm ready to start working on this feature. Please let me know if you have any specific requirements or suggestions!

Thank you!

baumann-t avatar May 09 '24 16:05 baumann-t

@baumann-t Thanks for pointing that out! I'll make a PR to update the docs to show that function is indeed available.

Would be great to work on a terminate_runs function with you! 👍

garethbrickman avatar May 09 '24 16:05 garethbrickman

Good morning @garethbrickman, I just opened a PR for the terminate_runs function, including the unit tests: https://github.com/dagster-io/dagster/pull/21775

Let me know what you think!

baumann-t avatar May 10 '24 14:05 baumann-t

@baumann-t Amazing thank you! Will block some time to review this next week. I'll keep you posted in the PR 👍

garethbrickman avatar May 10 '24 15:05 garethbrickman