dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Ignore Pyright error in create_dagster_package.py

Open maximearmstrong opened this issue 9 months ago • 1 comments

Summary & Motivation

This PR adds a #type: ignore to 2 lines in scripts/create_dagster_package.py so that Pyright stops yelling. No changes were made to the script in one year, so this is most likely coming from a new Pyright version.

Also, disables the Pyright rule reportUnnecessaryTypeIgnoreComment for the same reasons as in #21525

Local error:

python scripts/run-pyright.py --all
Creating temporary pyright config file at pyrightconfig-alt-1.json
Running pyright for environment `alt-1`...
  pyright --project=pyrightconfig-alt-1.json --outputjson --level=warning --warnings
Creating temporary pyright config file at pyrightconfig-master.json
Running pyright for environment `master`...
  pyright --project=pyrightconfig-master.json --outputjson --level=warning --warnings

/Users/maximearmstrong/Documents/Repositories/dagster-io/dagster/scripts/create_dagster_package.py:
  102:56: Argument of type "TextIOWrapper" cannot be assigned to parameter "fp" of type "str | IO[bytes]" in function "dump"
  Type "TextIOWrapper" cannot be assigned to type "str | IO[bytes]"
    "TextIOWrapper" is incompatible with "str"
    "TextIOWrapper" is incompatible with "IO[bytes]"
      Type parameter "AnyStr@IO" is invariant, but "str" is not the same as "bytes" (reportArgumentType)

  127:15: Argument of type "TextIOWrapper" cannot be assigned to parameter "fp" of type "str | IO[bytes]" in function "dump"
  Type "TextIOWrapper" cannot be assigned to type "str | IO[bytes]"
    "TextIOWrapper" is incompatible with "str"
    "TextIOWrapper" is incompatible with "IO[bytes]"
      Type parameter "AnyStr@IO" is invariant, but "str" is not the same as "bytes" (reportArgumentType)

pyright 1.1.356
Finished in 49.03 seconds
Analyzed 3440 files
Found 2 errors
Found 0 warnings
make: *** [pyright] Error 1

BK error

How I Tested These Changes

make rebuild_pyright_pins
make pyright

BK

maximearmstrong avatar May 07 '24 15:05 maximearmstrong

  • #21688 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

maximearmstrong avatar May 07 '24 15:05 maximearmstrong