dagster
dagster copied to clipboard
[DS][32/n] Update UpdatedSinceCronCondition
Summary & Motivation
First, realized that this wasn't actually tested. Added real tests, and updated the implementation to be slightly more efficient. In particular, previously whenever any partition of a given asset was updated since the previous tick (not near a cron boundary), we'd end up doing a somewhat-inefficient db query to get all the materialization events since the previous cron tick. Instead, we can just use the (probably already-fetched) information about materializations since the previous tick and keep track of that. Not a game changer or anything, but a bit nicer.
How I Tested These Changes
-
#21788
-
#21741
-
#21740
-
#21739
-
#21712
-
#21793
-
#21704
-
#21703
-
#21677
👈
-
#21737
-
#21671
: 1 other dependent PR (#21705
)
-
#21641
: 1 other dependent PR (#21670
)
-
#21640
-
#21648
-
#21615
-
#21613
-
#21612
-
#21573
-
#21546
-
#21545
-
#21541
-
#21540
-
#21539
-
#21538
-
#21537
-
#21536
-
#21535
-
#21521
-
#21520
-
#21511
: 1 other dependent PR (#21512
)
-
#21510
-
#21508
-
#21507
-
#21505
-
#21504
-
#21503
-
#21502
-
#21501
-
#21500
-
#21499
-
master
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @OwenKephart and the rest of your teammates on Graphite