dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Alert section for freshness checks

Open dpeng817 opened this issue 9 months ago • 2 comments

Adds an alerts section to the freshness guide.

I originally wanted to make more sweeping changes here, but it's proving more difficult than I thought. I think the biggest outstanding problem with the guide is thelack of reference to alerting (main important thing about freshness, so let's fix that first).

dpeng817 avatar May 06 '24 23:05 dpeng817

  • #21676 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dpeng817 and the rest of your teammates on Graphite Graphite

dpeng817 avatar May 06 '24 23:05 dpeng817

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io

Direct link to changed pages:

  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/_apidocs
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/assets/asset-checks
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/assets/asset-checks/checking-for-data-freshness
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/assets/asset-checks/define-execute-asset-checks
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/assets/asset-checks/subsetting-asset-checks
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/automation/schedules/automating-assets-schedules-jobs
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/automation/schedules/examples
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/concepts/automation/schedules/testing
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/dagster-plus/deployment/serverless
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/dagster-plus/managing-deployments/alerts
  • https://dagster-docs-d1ddv1u4c-elementl.vercel.app https://dpeng817-alert-section-freshness-docs.dagster.dagster-docs.io/integrations/embedded-elt/dlt docs/next/components/mdx/includes/dagster-cloud/AssetCheckAlerts

github-actions[bot] avatar May 06 '24 23:05 github-actions[bot]

Should we instead add this section to the asset checks page and link to it from the freshness checks page?

@sryza Which asset check page - this main category one, or this guide for defining checks? What's the thinking behind moving it?

erinkcochran87 avatar May 15 '24 19:05 erinkcochran87

@sryza Which asset check page - this main category one, or this guide for defining checks?

I honestly didn't think that far - I could see either, or even a third one.

What's the thinking behind moving it?

These instructions aren't really specific to freshness checks in particular. They apply for other asset checks as well.

sryza avatar May 15 '24 20:05 sryza

@dpeng817 Back to you - lmk what you think

erinkcochran87 avatar May 15 '24 21:05 erinkcochran87

Just waiting for BK, then I'll merge this guy

erinkcochran87 avatar May 16 '24 15:05 erinkcochran87