dagster
dagster copied to clipboard
dagster-io
[DS][30/n] Create new unique ids for each child based off of index
Summary & Motivation
This fixes an issue I noticed when experimenting with the PR above this (creating the eager condition).
If we base an evaluation node's id off of purely its description and its parent id, then we run into an issue if you have two children with the same description (but different sub-conditions).
This new scheme ensures that all nodes in the graph will have unique ids, as no two nodes can have the same parent id, description, AND index within that parent
How I Tested These Changes
-
#21671
: 2 dependent PRs (#21705 , #21737 ) 👈 -
#21641 : 1 other dependent PR (#21670 )
-
#21640
-
#21648
-
#21615
-
#21613
-
#21612
-
#21573
-
#21546
-
#21545
-
#21541
-
#21540
-
#21539
-
#21538
-
#21537
-
#21536
-
#21535
-
#21521
-
#21520
-
#21511 : 1 other dependent PR (#21512 )
-
#21510
-
#21508
-
#21507
-
#21505
-
#21504
-
#21503
-
#21502
-
#21501
-
#21500
-
#21499
-
master
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @OwenKephart and the rest of your teammates on Graphite
Deploy preview for dagster-university ready!
✅ Preview https://dagster-university-hen3s3nud-elementl.vercel.app https://05-06-Static-constructor-for-eager-condition.dagster-university.dagster-docs.io
Built with commit 4d384c0765dfb57b43a1ce2fb4ff0f110bf7a282. This pull request is being automatically deployed with vercel-action
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy preview for dagit-core-storybook ready!
✅ Preview https://dagit-core-storybook-i5ru78por-elementl.vercel.app https://05-06-Static-constructor-for-eager-condition.core-storybook.dagster-docs.io
Built with commit 4d384c0765dfb57b43a1ce2fb4ff0f110bf7a282. This pull request is being automatically deployed with vercel-action