dagster icon indicating copy to clipboard operation
dagster copied to clipboard
verified publisher icon dagster-io

[DS][25/n] Narrow extra_state type

Open OwenKephart opened this issue 1 year ago • 3 comments

Summary & Motivation

As title -- we only need a subset of the full PackableValue type, and can always widen this later

How I Tested These Changes

OwenKephart avatar May 02 '24 22:05 OwenKephart

  • #21641 Graphite: 2 dependent PRs (#21670 Graphite, #21671 Graphite)
  • #21640 Graphite
  • #21648 Graphite
  • #21615 Graphite
  • #21613 Graphite 👈
  • #21612 Graphite
  • #21573 Graphite
  • #21546 Graphite
  • #21545 Graphite
  • #21541 Graphite
  • #21540 Graphite
  • #21539 Graphite
  • #21538 Graphite
  • #21537 Graphite
  • #21536 Graphite
  • #21535 Graphite
  • #21521 Graphite
  • #21520 Graphite
  • #21511 Graphite: 1 other dependent PR (#21512 Graphite)
  • #21510 Graphite
  • #21508 Graphite
  • #21507 Graphite
  • #21505 Graphite
  • #21504 Graphite
  • #21503 Graphite
  • #21502 Graphite
  • #21501 Graphite
  • #21500 Graphite
  • #21499 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

OwenKephart avatar May 02 '24 22:05 OwenKephart

Fine with not giving it a name, but I don't want to mess with disallowing a singular AssetSubset at the moment (as we have plenty of already-stored information that is just a single AssetSubset)

OwenKephart avatar May 02 '24 23:05 OwenKephart

Makes complete sense to not change then given that we are dealing with already persisted data 👍🏻

schrockn avatar May 02 '24 23:05 schrockn

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 6:30 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 6:31 PM EDT: @OwenKephart merged this pull request with Graphite.

OwenKephart avatar May 03 '24 21:05 OwenKephart