dagster icon indicating copy to clipboard operation
dagster copied to clipboard

[DS][1/n] Create SchedulingConditionEvaluationContext

Open OwenKephart opened this issue 9 months ago • 1 comments

Summary & Motivation

Creates a new SchedulingConditionEvaluationContext. This is essentially a "fresh start" for rebuilding the context object, to make it easier to refactor / delete the current state of the AssetConditionEvaluationContext in the future. It has a greatly reduced set of properties and methods, which can be incrementally built up as needed.

It does keep around a reference to the legacy AssetConditionEvaluationContext, for the sole purpose of letting us keep the existing AutoMaterializeRule implementations untouched. In the eventual future where these are deleted, we can very easily sever the entire legacy context from our new context object.

Note that the weird Union[Scheduling...Context, Asset...Context] thing will go away upstack, so don't worry about that bit.

How I Tested These Changes

OwenKephart avatar Apr 29 '24 22:04 OwenKephart

  • #21511 Graphite: 2 dependent PRs (#21512 Graphite, #21520 Graphite)
  • #21510 Graphite
  • #21508 Graphite
  • #21507 Graphite
  • #21505 Graphite
  • #21504 Graphite
  • #21503 Graphite
  • #21502 Graphite
  • #21501 Graphite
  • #21500 Graphite
  • #21499 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

OwenKephart avatar Apr 29 '24 22:04 OwenKephart

Merge activity

  • May 3, 5:31 PM EDT: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • May 3, 5:33 PM EDT: @OwenKephart merged this pull request with Graphite.

OwenKephart avatar May 03 '24 21:05 OwenKephart