dagster
dagster copied to clipboard
fix: set postgres timeout args via query
Summary & Motivation
AWS RDS Proxy does not support cli options, so setting any mandatory connection options via statement improves compatibility. Any custom options are still passed through as prior
How I tested changes
- dagster_postgres pytests
-
dagster dev
and connect via rds proxy and directly, storage loads as expected
Resolves: #11762
Would be very happy if this gets merged! I'm experiencing the same issue. @garethbrickman have you guys noticed this PR?
@danielgafni Got this one on the agenda to review, thanks for the reminder! 👍
@garethbrickman or @jmsanders Have you had a chance to review this? Quite a few people would like to use RDS proxies for connection pooling, etc and this is blocking that.
I need to give it a test setting the timeout on the connection event, will shout when done.
This iteration passes python -m pytest python_modules/libraries/dagster-postgres/dagster_postgres_tests
, time to see what buildkite says.
@jhlwscom seeing some test failures here in the dagster-postgres package that look potentially relevant: "TypeError: DefaultEngineStrategy.create() missing 1 required positional argument: 'name_or_url'"
Sorry for the delay on that tweak, was camping.