dagster icon indicating copy to clipboard operation
dagster copied to clipboard

fix: set postgres timeout args via query

Open jhlwscom opened this issue 10 months ago • 2 comments

Summary & Motivation

AWS RDS Proxy does not support cli options, so setting any mandatory connection options via statement improves compatibility. Any custom options are still passed through as prior

How I tested changes

  • dagster_postgres pytests
  • dagster dev and connect via rds proxy and directly, storage loads as expected

Resolves: #11762

jhlwscom avatar Apr 22 '24 17:04 jhlwscom

Would be very happy if this gets merged! I'm experiencing the same issue. @garethbrickman have you guys noticed this PR?

danielgafni avatar May 20 '24 09:05 danielgafni

@danielgafni Got this one on the agenda to review, thanks for the reminder! 👍

garethbrickman avatar May 20 '24 20:05 garethbrickman

@garethbrickman or @jmsanders Have you had a chance to review this? Quite a few people would like to use RDS proxies for connection pooling, etc and this is blocking that.

telderfts avatar Jun 10 '24 23:06 telderfts

I need to give it a test setting the timeout on the connection event, will shout when done.

jhlwscom avatar Jun 11 '24 08:06 jhlwscom

This iteration passes python -m pytest python_modules/libraries/dagster-postgres/dagster_postgres_tests, time to see what buildkite says.

jhlwscom avatar Jun 11 '24 09:06 jhlwscom

@jhlwscom seeing some test failures here in the dagster-postgres package that look potentially relevant: "TypeError: DefaultEngineStrategy.create() missing 1 required positional argument: 'name_or_url'"

gibsondan avatar Jun 12 '24 19:06 gibsondan

Sorry for the delay on that tweak, was camping.

jhlwscom avatar Jun 17 '24 14:06 jhlwscom