dagster icon indicating copy to clipboard operation
dagster copied to clipboard

Possible memory leak on very long running `dagster-webserver`/Daemon containers

Open cody-scott opened this issue 10 months ago • 4 comments

Dagster version

1.7.1

What's the issue?

Web UI and Daemon when running for a long period of time (months) without restarting, progressively uses additional memory until restarted.

Example here is we had an older version of dagster running (1.6.0) since February. When we updated to the newest version this week it released a large amount of memory and recovered back up to the original starting point.

Running OSS on Ubuntu in docker on a single machine.

image

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

None

Deployment details

Ubuntu 22.04 docker compose for webserver + daemon images

Additional information

Unclear if this is a docker issue holding on to memory, or if this is a dagster daemon/webserver holding on. Will let it run again to see if it appears.

Additionally, is the best practice to frequently restart the webserver/daemons to avoid this.

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

cody-scott avatar Apr 19 '24 13:04 cody-scott

This could be a duplicate of https://github.com/dagster-io/dagster/issues/18997, and the solution in there is to downgrade and pin the grpcio python package to 1.57.0.

garethbrickman avatar Apr 19 '24 19:04 garethbrickman

Perfect! I'll try it out next week.

cody-scott avatar Apr 19 '24 20:04 cody-scott

@garethbrickman, the link you referenced points to an internal repo, is there a publicly accessible PR to track progress on this? Thanks!

shivonchain avatar Apr 23 '24 19:04 shivonchain

@shivonchain Ah my apologies I linked that erroneously and have removed it. It was not a fix but an internal test.

garethbrickman avatar Apr 23 '24 19:04 garethbrickman